interfaces/builtin: add xdg-portal-permission-store interface - #17029
Merged
Conversation
Contributor
Author
|
Related to: #15338 |
olivercalder
added
Needs Samuele review
|
Thu Jun 11 11:53:12 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17029 +/- ##
==========================================
- Coverage 79.18% 79.12% -0.06%
==========================================
Files 1374 1387 +13
Lines 193037 193283 +246
Branches 2466 2466
==========================================
+ Hits 152855 152937 +82
- Misses 30994 31160 +166
+ Partials 9188 9186 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
It seems like the 4 failing checks are flakes? They don't appear related to this PR. |
3v1n0
reviewed
May 7, 2026
quine00
changed the title
Contributor
Author
|
Pinging for snapd team review |
olivercalder
left a comment
olivercalder
left a comment
Member
There was a problem hiding this comment.
Generally LGTM, I'm wondering if there's a way to test that a snap with this interface can actually interact with the PermissionStore as expected.
quine00
force-pushed
the
impl-pps
branch
2 times, most recently
from
June 2, 2026 13:49
6e2d44b to
a4251a0
Compare
olivercalder
reviewed
Jun 2, 2026
olivercalder
left a comment
olivercalder
left a comment
Member
There was a problem hiding this comment.
This is looking great, nice job on the spread test. I'm almost +1, the one blocker for me is making sure we exercise that each of the commands in the test snap fails when the interface is disconnected.
bboozzoo
reviewed
Jun 3, 2026
quine00
force-pushed
the
impl-pps
branch
3 times, most recently
from
June 3, 2026 16:23
c3b35cb to
f1cc07c
Compare
olivercalder
approved these changes
Jun 4, 2026
olivercalder
left a comment
olivercalder
left a comment
Member
There was a problem hiding this comment.
Nice, the changes look excellent, thank you!
By the way, we generally avoid amending commits and force-pushing (or even rebasing on master without good reason), as it makes it more difficult to track what changes between reviews. We will squash merge the PR after it's approved, so we'd much rather have a rich commit history during the review process, and we can always clean it up when merging.
github-actions
Bot
added
the
Auto rerun spread
Contributor
Author
Thanks Oliver, I'll do that in the future here. I have disabled Arch systems in the new test with the latest commit. There appears to be AppArmor mismatches there. |
Contributor
Author
|
Gentle ping. I don't think any of the CI failures are related to my changes. |
Contributor
|
@quine00 can you rebase on latest master to include a fix for one of the failing tests? |
added 2 commits
June 10, 2026 10:41
Provide a dedicated super-privileged interface for xdg-desktop-portal PermissionStore access. Also add a spread test that starts a fake PermissionStore service on the session bus and verifies that a confined snap can only talk to it when xdg-portal-permission-store is connected.
There appears to be an issue with the version of AppArmor in the Arch images. Disable for now. ``` 2026-06-04 04:49:00 Error executing openstack:arch-linux-64:tests/main/interfaces-xdg-portal-permission-store (jun040444-442035) : ----- + apps='ping introspect get-all test' + echo 'The interface is initially disconnected' The interface is initially disconnected + snap interfaces -i xdg-portal-permission-store + MATCH -- '- +test-snapd-xdg-portal-permission-store:xdg-portal-permission-store' 'snap interfaces' is deprecated; use 'snap connections'. + echo 'Without the connection, each PermissionStore access is denied' Without the connection, each PermissionStore access is denied + for app in $apps + not tests.session -u test exec test-snapd-xdg-portal-permission-store.ping ok ```
Contributor
Author
Done, thanks for looking. |
Contributor
Author
|
Looking at the CI failures,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a dedicated super-privileged interface for xdg-desktop-portal PermissionStore access